Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Put deprecation notice on old docs #2417

Merged
merged 1 commit into from
Jan 3, 2018

Conversation

chenglou
Copy link
Member

Tried really hard to generate the new doc page, couldn't find out how. @bobzhang could you please generate the html perhaps one last time from your side? Thanks

@@ -1,96 +0,0 @@
<!DOCTYPE html>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is bucklescript.github.io/bucklescript. Not needed anymore

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need a redirect?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. This page doesn't contain much info. We can let it 404 and folks can just point to the new site. We have the redirect logic for all other pages, but not turned on yet.

Tried really hard to generate the new doc page, couldn't find out how. @bobzhang could you please generate the html perhaps one last time from your side? Thanks
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 1082d7b on chenglou:dep into ** on BuckleScript:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 1082d7b on chenglou:dep into ** on BuckleScript:master**.

@bobzhang bobzhang merged commit 034a4a5 into rescript-lang:master Jan 3, 2018
@chenglou chenglou deleted the dep branch January 3, 2018 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants