Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP New runtime encoding #95

Merged
merged 2 commits into from
Feb 16, 2016
Merged

WIP New runtime encoding #95

merged 2 commits into from
Feb 16, 2016

Conversation

bobzhang
Copy link
Member

No description provided.

@@ -13,19 +13,16 @@ var $$String = require("./string");
var List = require("./list");

var Bad = [
248,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense to keep it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed

@bobzhang
Copy link
Member Author

note we need update to use Object.defineProperty, see the discussion in #24

bobzhang added a commit that referenced this pull request Feb 16, 2016
@bobzhang bobzhang merged commit 3ddc114 into master Feb 16, 2016
@bobzhang bobzhang deleted the new_runtime_encoding branch April 12, 2016 14:22
kevinbarabash pushed a commit to kevinbarabash/rescript-compiler that referenced this pull request Dec 24, 2021
* Enable roundtrip-tests on ci.

It provides stronger tests:
- Napkin is bootstrapped
- Equality check between the Parsetree from different parsers
- prints napkin code twice to check for inconsistencies.

* Comment out Refmt bug to make roundtrip-tests pass.

We should really fix this at the refmt level…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant