Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to build with gnome-desktop 43 #31

Closed
jbicha opened this issue Jul 28, 2022 · 2 comments
Closed

Fails to build with gnome-desktop 43 #31

jbicha opened this issue Jul 28, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@jbicha
Copy link
Contributor

jbicha commented Jul 28, 2022

Description

budgie-control-center fails to build with gnome-desktop 43 Alpha

Budgie version

budgie-control-center 1.0.2-2 on Debian/Ubuntu

Actual result

../panels/background/cc-background-chooser.c: In function ‘on_file_chooser_selection_changed_cb’:
../panels/background/cc-background-chooser.c:266:20: error: too few arguments to function ‘gnome_desktop_thumbnail_factory_generate_thumbnail’
  266 |           pixbuf = gnome_desktop_thumbnail_factory_generate_thumbnail (thumbnail_factory,
      |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../panels/background/cc-background-chooser.c:25:
/usr/include/gnome-desktop-3.0/libgnome-desktop/gnome-desktop-thumbnail.h:84:13: note: declared here
   84 | GdkPixbuf * gnome_desktop_thumbnail_factory_generate_thumbnail (GnomeDesktopThumbnailFactory *factory,
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Additional information

gnome-desktop 43 Alpha is available in Debian experimental

It's possible to update the code so that it builds against the old gnome-desktop API and the new one. Here's an example from cheese

gnome-control-center 42 has a rewritten Background page which uses the gnome-desktop thumbnailer API differently and therefore wasn't affected by this issue

@fossfreedom fossfreedom added the bug Something isn't working label Jul 29, 2022
@fossfreedom
Copy link
Contributor

corresponding debian bug report - https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1016175

fossfreedom added a commit that referenced this issue Aug 2, 2022
@jbicha
Copy link
Contributor Author

jbicha commented Aug 2, 2022

Thank you!!

@jbicha jbicha closed this as completed Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants