Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raven's "Clear Notifications" keyboard shortcut no longer working after 10.6 update #75

Closed
nathanpainchaud opened this issue Mar 18, 2022 · 4 comments · Fixed by #76
Closed
Labels
bug Something isn't working

Comments

@nathanpainchaud
Copy link

nathanpainchaud commented Mar 18, 2022

Description

The keyboard shortcut for clearing notifications in Raven (Super+C by default) no longer works. Only the notifications' applet gets reinitialized, but the notifications still are not cleared in Raven. The shortcut was working fine up until Budgie 10.5, but stopped working for me with the recent Budgie 10.6 update (on Solus).

Budgie version

Budgie 10.6

Operating system

Solus 4.3

Steps to reproduce the issue

Receive a notification in Raven. Try to clear it using the keyboard shortcut. Look to see if the notification is still there.

EDIT: Added screenshot of notifications before clear.
new_notification

Actual result

The notifications are still there.

EDIT: Added screenshot of notifications after clear.
after_clearing_notifications

Expected result

The notifications should have been removed, just as they are when manually clicking on the clear notifications button in Raven.

Additional information

image

@JoshStrobl
Copy link
Member

Unable to reproduce under EndeavourOS.

@fossfreedom
Copy link
Contributor

hmm - yep - reproducible under UB 22.04

@fossfreedom
Copy link
Contributor

fossfreedom commented Mar 18, 2022

umm.... maybe mistaken ... but I'm guessing nothing is now connected to this signal? https://github.com/BuddiesOfBudgie/budgie-desktop/blob/master/src/raven/raven.vala#L68 and https://github.com/BuddiesOfBudgie/budgie-desktop/blob/master/src/raven/raven.vala#L136 which is invoked from a super+C

@JoshStrobl
Copy link
Member

@fossfreedom Super+C invokes the DBus signal via https://github.com/BuddiesOfBudgie/budgie-desktop/blob/master/src/wm/wm.vala#L302

Code is unchanged in those areas.

@serebit serebit added the bug Something isn't working label Mar 18, 2022
EbonJaeger added a commit that referenced this issue Mar 18, 2022
Fixes #75

Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net>
JoshStrobl pushed a commit that referenced this issue Mar 19, 2022
Fixes #75

Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net>
serebit pushed a commit that referenced this issue Mar 29, 2022
Fixes #75

Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants