Improve scaling change message to request further user action. #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing of various scaling changes across different monitor and graphic driver types shows that budgie desktop popovers and other elements of the GUI do not always refresh correctly. As a quick win lets prompt the user to restart their session to allow the desktop to refresh & resize properly.
80-col bad, please fix. That being said, I can't land this with it looking that way. Super bork. |
JoshStrobl
requested changes
May 9, 2022
|
|
|
LGTM. Went ahead and updated the description since it was hard wrapping after 80 columns. PR itself looks good. Thanks! |
JoshStrobl
approved these changes
May 13, 2022
JoshStrobl
pushed a commit
that referenced
this pull request
Aug 21, 2022
* Improve scaling change message to request further user action. Testing of various scaling changes across different monitor and graphic driver types shows that budgie desktop popovers and other elements of the GUI do not always refresh correctly. As a quick win lets prompt the user to restart their session to allow the desktop to refresh & resize properly. * Write our own version of Meta.Util.show_dialog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing of various scaling changes across different monitor and graphic driver types shows that budgie desktop popovers and other elements of the GUI do not always refresh correctly. As a quick win lets prompt the user to restart their session to allow the desktop to refresh & resize properly.
As an aside there doesn't appear to be any way to force mutter based dialogs to ensure messages span over more than one button. Odd - just odd.
As discussed on matrix/development with @EbonJaeger - but tried to further reduce the message size to improve appearance without affecting potential translation understanding.
Submitter Checklist
git rebase -i(if needed)