Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set sourceId so that changing display name doesn't hide table #10769

Conversation

melohagan
Copy link
Collaborator

Description

The table was disappearing because it was being filtered out of the list:

$: sortedTables = $tables.list
    .filter(table => table.sourceId === sourceId)
    .sort(alphabetical)

A line of code has been added to make sure the sourceId of the table is saved.

Addresses:

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2023

Codecov Report

Merging #10769 (3f0313e) into master (311c9d5) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master   #10769   +/-   ##
=======================================
  Coverage   49.95%   49.95%           
=======================================
  Files         153      153           
  Lines        5167     5167           
  Branches     1033     1033           
=======================================
  Hits         2581     2581           
  Misses       2368     2368           
  Partials      218      218           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@melohagan melohagan merged commit 83e93fb into master Jun 7, 2023
8 checks passed
@melohagan melohagan deleted the budi-6992-table-disappears-from-side-bar-when-changing-display-name branch June 7, 2023 13:01
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants