Server relationship tests #1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating the server test cases to coverage the
packages/server/src/db/linkedRowsset of functionality. This didn't have great coverage initially and had been a real source of bugs, we had to do a lot of work to get this functioning as expected.There is now 100% coverage specifically in the
LinkControllerwhich is where all of the primary logic that drives relationships is stored and was the source of all relationship bugs. This should make it much easier to adjust in the future.In combination with the integrations test suite (#1295) coverage across the server codebase is raised to 92.5% with 95% of functions in the system tested.
Screenshots
Coverage of linked rows directory after test cases added:
