Replace uses of test.com with example.com #12993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m and create a lint rule to prevent this in future.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The domain
test.comis privately owned and could, in theory, point anywhere. If we accidentally were to issue requests to it from our tests it's unclear what might happen. It's much safer to useexample.com, which is owned by IANA and is part of the RFC2606 reserved domains.This PR replaces all uses of
test.comwithexample.comand introduces a lint rule to prevent future uses oftest.com.Related PR: https://github.com/Budibase/budibase-pro/pull/262