Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vm2 from stringtemplates #12994

Merged
merged 7 commits into from Feb 9, 2024
Merged

Conversation

adrinr
Copy link
Collaborator

@adrinr adrinr commented Feb 8, 2024

Description

Removing vm2 from string-templates. This is not used anymore, only for tests, that will use vm for now

Feature branch env

Feature Branch Link

@adrinr adrinr force-pushed the remove-vm2-from-stringtemplates branch from 52294b7 to 0539e0b Compare February 8, 2024 17:20
@adrinr adrinr added firestorm Data/Infra/Revenue Team feature-branch Release this PR code into a feature branch labels Feb 8, 2024
Copy link
Collaborator

@mike12345567 mike12345567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrinr adrinr force-pushed the remove-vm2-from-stringtemplates branch from fd760a1 to 2cde033 Compare February 9, 2024 09:28
Copy link
Member

@shogunpurple shogunpurple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrinr adrinr marked this pull request as ready for review February 9, 2024 12:28
@adrinr adrinr requested a review from a team as a code owner February 9, 2024 12:28
@adrinr adrinr requested review from samwho and removed request for a team February 9, 2024 12:28
@adrinr adrinr enabled auto-merge February 9, 2024 12:41
@adrinr adrinr merged commit 7cbef52 into master Feb 9, 2024
12 checks passed
@adrinr adrinr deleted the remove-vm2-from-stringtemplates branch February 9, 2024 12:47
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-branch Release this PR code into a feature branch firestorm Data/Infra/Revenue Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants