Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Error when deleting selected rows that have attachment #13006

Conversation

melohagan
Copy link
Collaborator

Description

Table (and Table block) rows that have attachment columns can now be deleted via the new Selected rows binding which can be found under those settings.

The old binding has been updated to read Selected Row IDs (DEPRECATED) to indicate that it should no longer be used. It can be deleted in five minor versions time as per support policy.

Addresses

Screenshots

BEFORE
old binding

old delete

AFTER
deprecated label
The old binding will work as before, but the label has been updated to warn the user

new binding
New selected rows binding is now found under the Table block/Table bindings

full bindings
Full row data is now provided, not just the _ids

delete rows
Delete rows bug now fixed with the new binding

Copy link

linear bot commented Feb 9, 2024

@melohagan melohagan changed the title Error when deleting selected rows that have attachment FIX: Error when deleting selected rows that have attachment Feb 9, 2024
Copy link
Contributor

@deanhannigan deanhannigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@aptkingston aptkingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just change the all uppercase DEPRECATED to just deprecated to look less intimidating, but otherwise LGTM!

@melohagan melohagan enabled auto-merge (squash) February 13, 2024 16:40
@melohagan melohagan merged commit f8073c3 into master Feb 13, 2024
12 checks passed
@melohagan melohagan deleted the budi-7996-error-when-deleting-selected-rows-that-have-attachment branch February 13, 2024 16:44
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants