-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Error when deleting selected rows that have attachment #13006
Merged
melohagan
merged 11 commits into
master
from
budi-7996-error-when-deleting-selected-rows-that-have-attachment
Feb 13, 2024
Merged
FIX: Error when deleting selected rows that have attachment #13006
melohagan
merged 11 commits into
master
from
budi-7996-error-when-deleting-selected-rows-that-have-attachment
Feb 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melohagan
changed the title
Error when deleting selected rows that have attachment
FIX: Error when deleting selected rows that have attachment
Feb 9, 2024
deanhannigan
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…s-that-have-attachment
aptkingston
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd just change the all uppercase DEPRECATED
to just deprecated
to look less intimidating, but otherwise LGTM!
…s-that-have-attachment
…ttachment' of https://github.com/Budibase/budibase into budi-7996-error-when-deleting-selected-rows-that-have-attachment
…s-that-have-attachment
melohagan
deleted the
budi-7996-error-when-deleting-selected-rows-that-have-attachment
branch
February 13, 2024 16:44
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Table (and Table block) rows that have attachment columns can now be deleted via the new Selected rows binding which can be found under those settings.
The old binding has been updated to read Selected Row IDs (DEPRECATED) to indicate that it should no longer be used. It can be deleted in five minor versions time as per support policy.
Addresses
Screenshots
BEFORE
AFTER
The old binding will work as before, but the label has been updated to warn the user
New selected rows binding is now found under the Table block/Table bindings
Full row data is now provided, not just the _ids
Delete rows bug now fixed with the new binding