Create Redis bulk store utils #13197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samwho
reviewed
Mar 6, 2024
samwho
reviewed
Mar 6, 2024
| ` | ||
| const keys = Object.keys(dataToStore) | ||
| const values = Object.values(dataToStore) | ||
| const pipeline = client.pipeline() |
There was a problem hiding this comment.
Pipelines aren't guaranteed to be atomic. I don't believe that is important for this code, the worse that can happen is the expiry is overwritten with a slightly different time, but just wanted to point it out in case you can think of a reason it would matter.
There was a problem hiding this comment.
Pipelines are meant to be leaner, I think they should be fine for this use case
samwho
approved these changes
Mar 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a new util into our redis implementation to allow bulk stores. We use redis pipelines to perform this action atomically on the redis server
Addresses
Launchcontrol
Adding
redis.bulkStorefunction