Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Group members edits only for admins #13230

Merged
merged 4 commits into from Mar 11, 2024
Merged

Conversation

adrinr
Copy link
Collaborator

@adrinr adrinr commented Mar 11, 2024

Description

With the previous builder users, we have some users who can visualise users without being admins. We don't want these to edit roles, encouraging them to migrate to the new roles.
This PR unifies the UI and endpoints, allowing only users to perform these actions.

Related:

Launchcontrol

Group member add/remove only for admins

@adrinr adrinr requested a review from aptkingston March 11, 2024 14:17
Copy link
Member

@aptkingston aptkingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adrinr adrinr enabled auto-merge March 11, 2024 15:46
@adrinr adrinr merged commit 86926ad into master Mar 11, 2024
12 checks passed
@adrinr adrinr deleted the fix/group-member-protection branch March 11, 2024 15:52
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants