Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group fields protection #13233

Merged
merged 9 commits into from
Mar 12, 2024
Merged

Group fields protection #13233

merged 9 commits into from
Mar 12, 2024

Conversation

adrinr
Copy link
Collaborator

@adrinr adrinr commented Mar 12, 2024 •
edited

Description

Fixing group edition and messaging for old builder users. Also fixing some edge cases with SCIM group editions and adding extra tests.

Related:

Launchcontrol

Fixing group edition and messaging for old builder users

@adrinr adrinr requested a review from a team as a code owner March 12, 2024 08:58
@adrinr adrinr requested review from mike12345567 and removed request for a team March 12, 2024 08:58
aptkingston
aptkingston approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@aptkingston aptkingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice to have tests to ensure this stays working too 👍

samwho
samwho approved these changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@samwho samwho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminds me I need to update TestConfiguration and friends in the workers package someday 😄

@adrinr adrinr merged commit 4f30c45 into master Mar 12, 2024
12 checks passed
@adrinr adrinr deleted the fix/group-fields-protection branch March 12, 2024 09:28
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samwho samwho samwho approved these changes

@aptkingston aptkingston aptkingston approved these changes

@mike12345567 mike12345567 Awaiting requested review from mike12345567 mike12345567 is a code owner automatically assigned from Budibase/backend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adrinr @samwho @aptkingston