Remove jest testcontainers #13350
Remove jest testcontainers #13350
Conversation
| @@ -27,7 +27,7 @@ class Replication { | |||
| return resolve(info) | |||
| }) | |||
| .on("error", function (err) { | |||
| throw new Error(`Replication Error: ${err}`) | |||
| throw err | |||
There was a problem hiding this comment.
This caused an error in a test while I was working on this change, and I moved to throwing the raw error in order to see the full stack trace. Decided to leave it as is because I feel this is more useful.
| @@ -1,85 +1,66 @@ | |||
| import { DatabaseImpl } from "../../../src/db" | |||
There was a problem hiding this comment.
I've changed how this file works because when I moved away from jest-testcontainers, this code started crafting invalid CouchDB URLs.
The new code uses docker ps --format json to make parsing the output easier, and it also makes sure to always return testcontainers containers by looking for the org.testcontainers=true label.
There was a problem hiding this comment.
This is a nice improvement, I didn't even know you could get JSON out here, very handy!
| @@ -0,0 +1,2 @@ | |||
| [log] | |||
There was a problem hiding this comment.
I've taken the opportunity here to calm the CouchDB logs down. By default they log every single HTTP request, which is an unbelievable amount of logging. This made DEBUG=testcontainers* unusable, whereas with level = warn the output is a little less huge and more useful.
Description
While working on the Postgres unmocking PR, I noticed that when we run tests, there are two copies of the
testcontainers/ryukcontainer running. One as version0.3.0and another as0.5.1.On closer inspection, it appears that the
jest-testcontainerspackage is depending ontestcontainers@4.7.0while the Budibase project depends ontestcontainers@10.7.2.This discrepancy doesn't seem ideal, so I've removed
jest-testcontainersin the hope it may help with some of the flakiness we've been seeing. I have no proof that it will, but this at least removes this discrepancy as a culprit.Pro PR: https://github.com/Budibase/budibase-pro/pull/285