Fix issues with colours in app skeletons #13355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ghrehh
approved these changes
Mar 26, 2024
You had it working, it was me who old told you to remove the extra CSS vars which revealed the real issue! |
|
Seems to be failing due to some account portal issue. I don't even want to bump the account portal of course, but I'm forced to do so, so now this is forced to be broken until that issue is resolved. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where certain colours are not correct in the app skeleton. This is because we weren't properly setting the required spectrum classes. This only affect our custom themes - Nord and Midnight.
Before:
After:
Launchcontrol
Fix app skeleton colours for Nord and Midnight themes.