Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Devtools crashing app preview #13396

Merged
merged 2 commits into from Apr 3, 2024
Merged

Conversation

adrinr
Copy link
Collaborator

@adrinr adrinr commented Apr 3, 2024

Description

We found an issue when a user is loading the preview of an app with the BB devtools open. There is a race condition with the authStore, causing the following error:
image

To reproduce the error:

  1. Open an app preview
  2. Open the BB devtools
  3. Reload the page
  4. An js error will break the load of the app

Launchcontrol

Fixing a reported issue causing app previews to not load

@adrinr adrinr requested a review from aptkingston April 3, 2024 13:41
@adrinr adrinr merged commit 23b5b05 into master Apr 3, 2024
10 checks passed
@adrinr adrinr deleted the fix/devtools-preview-loading branch April 3, 2024 14:06
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants