New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single attachment column type #13399
Single attachment column type #13399
Conversation
…-singleattachment Clean and populate url for single attachment
…-attachment-column-type
…-attachment-column-type
…-attachment-column-type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add attachmentsinglefield
to componentStructure.json
as otherwise it won't appear as a possible component to add.
Few more bits to review but have a screaming baby to attend to! So here's some initial feedbacl.
packages/frontend-core/src/components/grid/cells/AttachmentSingleCell.svelte
Show resolved
Hide resolved
packages/client/src/components/app/forms/AttachmentField.svelte
Outdated
Show resolved
Hide resolved
…-attachment-column-type
Handle singleattachment on AttachmentCleanup
…-attachment-column-type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than that one question 👍
…-attachment-column-type
Description
Adding a new column type for single attachments. This will be stored as the same shape as the current attachments, but as a single object (instead of an array). Having this new type will allow having columns with a single attachment, simplifying validations and bindings.
After discussing with @AndyWhann and @aptkingston, we are also changing the current attachment column to use paperclips icons, to match usages in the design section.
Screenshots
Builder
Adding a new single attachment column
Data section
Editing an empty cell
Editing a none empty cell (will not allow adding more than one file)
Required single attachment validation
Adding a new field component
Client
Inline editing grid
This will work like on the builder end
Grid with side panel
New row
It will not allow adding more than one image for single attachments
Editing existing row
Form block
It will act as the side panel
New row
Editing row
Multistep block
Repeater with images
Launchcontrol
Adding a new column type single attachment
Feature branch env
Feature Branch Link