Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single attachment column type #13399

Merged

Conversation

mike12345567
Copy link
Collaborator

@mike12345567 mike12345567 commented Apr 3, 2024

Description

Adding a new column type for single attachments. This will be stored as the same shape as the current attachments, but as a single object (instead of an array). Having this new type will allow having columns with a single attachment, simplifying validations and bindings.

After discussing with @AndyWhann and @aptkingston, we are also changing the current attachment column to use paperclips icons, to match usages in the design section.

Screenshots

Builder

Adding a new single attachment column

image

Data section

Editing an empty cell
image
Editing a none empty cell (will not allow adding more than one file)

image

Required single attachment validation

image

Adding a new field component

image
image

Client

Inline editing grid

This will work like on the builder end
image

Grid with side panel

New row
image

It will not allow adding more than one image for single attachments
image

Editing existing row
image

Form block

It will act as the side panel

New row
image
Editing row
image

Multistep block

image

Repeater with images

image

Launchcontrol

Adding a new column type single attachment

Feature branch env

Feature Branch Link

@mike12345567 mike12345567 added the firestorm Data/Infra/Revenue Team label Apr 3, 2024
@mike12345567 mike12345567 self-assigned this Apr 3, 2024
@mike12345567 mike12345567 requested a review from a team as a code owner April 3, 2024 15:06
@mike12345567 mike12345567 requested review from samwho and removed request for a team April 3, 2024 15:06
Copy link

linear bot commented Apr 3, 2024

@mike12345567 mike12345567 removed their assignment Apr 3, 2024
@mike12345567 mike12345567 requested review from adrinr and removed request for samwho April 3, 2024 15:06
@adrinr adrinr requested a review from aptkingston April 3, 2024 15:09
@adrinr adrinr added the feature-branch Release this PR code into a feature branch label Apr 3, 2024
@adrinr adrinr changed the title Re-introduce single attachment column type Single attachment column type Apr 3, 2024
Copy link
Member

@aptkingston aptkingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add attachmentsinglefield to componentStructure.json as otherwise it won't appear as a possible component to add.

Few more bits to review but have a screaming baby to attend to! So here's some initial feedbacl.

packages/client/manifest.json Outdated Show resolved Hide resolved
packages/client/manifest.json Show resolved Hide resolved
@adrinr
Copy link
Collaborator

adrinr commented Apr 10, 2024

attachmentsinglefield

The existing attachment list uses a clip instead of the folder we use in the data section. Would you use the clip as well for this new column as well?

image

@adrinr adrinr requested a review from aptkingston April 10, 2024 08:17
Copy link
Member

@aptkingston aptkingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than that one question 👍

@adrinr adrinr enabled auto-merge April 10, 2024 11:38
@adrinr adrinr merged commit 8c5b62e into master Apr 10, 2024
10 checks passed
@adrinr adrinr deleted the revert-13398-revert-13356-BUDI-8122/single-attachment-column-type branch April 10, 2024 11:49
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-branch Release this PR code into a feature branch firestorm Data/Infra/Revenue Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants