Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console.error lint rule #13448

Merged
merged 6 commits into from
Apr 19, 2024
Merged

Console.error lint rule #13448

merged 6 commits into from
Apr 19, 2024

Conversation

shogunpurple
Copy link
Member

Description

OIDC logging was not occurring because we were only doing console.log(err), which caused pino to skip it. Originally put a fix in to support console.error(err), but decided against it for a few reasons:

  • we essentially have this nowhere else in the codebase.
  • There are times we may want to log an error in the pod but not to DD
  • It's more explicit to add a message before you pass the error object. It's easier to grep, and clearer by reading the code instead of having to debug at runtime.

@shogunpurple shogunpurple requested a review from a team as a code owner April 10, 2024 16:15
@shogunpurple shogunpurple requested review from adrinr and removed request for a team April 10, 2024 16:15
@shogunpurple shogunpurple changed the title Update auth.ts Console.error lint rule Apr 10, 2024
Copy link
Collaborator

@adrinr adrinr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! There are still some linting issues left

@mike12345567 mike12345567 merged commit 802b388 into master Apr 19, 2024
10 checks passed
@mike12345567 mike12345567 deleted the fix-oidc-error-logging branch April 19, 2024 12:37
@github-actions github-actions bot locked and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants