Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename search.spec.ts helpers to better reflect their purpose. #13484

Merged
merged 2 commits into from Apr 12, 2024

Conversation

samwho
Copy link
Collaborator

@samwho samwho commented Apr 12, 2024

Description

This was bothering me as I worked through some new tests so I split it out into its own PR. toContains implies extra rows would be fine, but that's not what the assertion does. I've changed it to toContainsExactly to reflect that additional rows will cause a test failure. I've also introduced a toContains that works as expected.

@samwho samwho added the firestorm Data/Infra/Revenue Team label Apr 12, 2024
@samwho samwho requested a review from a team as a code owner April 12, 2024 15:46
@samwho samwho marked this pull request as draft April 12, 2024 15:59
@samwho samwho marked this pull request as ready for review April 12, 2024 16:01
Base automatically changed from slim-down-integration-tests to master April 12, 2024 16:03
@samwho samwho enabled auto-merge April 12, 2024 16:18
Copy link
Collaborator

@mike12345567 mike12345567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samwho samwho merged commit cb11a16 into master Apr 12, 2024
10 checks passed
@samwho samwho deleted the rename-test-helpers branch April 12, 2024 16:24
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firestorm Data/Infra/Revenue Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants