Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore render blocker around client apps until data is ready #13513

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

aptkingston
Copy link
Member

Description

This PR adds back in the render blocker around client apps until data is ready. We always used to have this, but it was removed recently as part of the new app skeleton work to smooth out a few frames of jank from the initial load.

Unfortunately this has caused a few issues so needs to be reverted. This also has the bonus of reducing multiple wasted API calls.

Addresses

Copy link
Contributor

@deanhannigan deanhannigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aptkingston aptkingston merged commit ebd7f33 into master Apr 19, 2024
10 checks passed
@aptkingston aptkingston deleted the fix-client-loading-issues branch April 19, 2024 09:57
@github-actions github-actions bot locked and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants