Fix for onEmptyFilter getting stuck on internal datasource filters. #13529
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
onEmptyFilter
filter gets stuck in the filter list when all filter fields are removed. If you had previously set this filter tonone
it will cause the filter to always return zero rows. The only way to get around it is to refresh or add in fields to make theonEmptyFilter
UI visible again.Addresses
Clears the
onEmptyFilter
when all field filters have been removed. This ensures that all rows continue to be returned when no fields are specified.Steps
Data
section and open the filter menuWhen filter empty
toReturn no rows
When filter empty
option being hidden, theonEmptyFilter
is still present in the filter UX and will cause no rows to appear.The same behaviour can be seen when filtering datasources on components in the builder.
Screenshots
Launchcontrol
Minor fix to ensure onEmptyFilter is cleared from datasource filters when no fields are specified.