Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single user column type #13543

Merged
merged 51 commits into from May 3, 2024

Conversation

adrinr
Copy link
Collaborator

@adrinr adrinr commented Apr 22, 2024

Description

Adding a new column type for single users. These new columns will return the data as an object, instead of the existing bb-reference that returns an array, allowing better validation and cleaner bindings.
No existing data will be migrated, the old columns will still return objects and it will keep the constraints validations (allowing multiple or single when required)

With this change, we will have the following strategy:

  1. The bb_reference will be a type that will store an array of internal IDs
  2. The bb_reference_single will be a type that will store a single internal ID
  3. Both column types will have a subtype. For the time being only user subtype is allowed, but technically it can support any internal reference such as apps, groups, tables... The subtype will define:
    i. Input validation: are the IDs valid for that object?
    ii. Output enhancement: what other data needs to be populated when enhancing the id

Addresses

Screenshots

Adding a single-user column

Before After
image image

Adding a multi-user column

Before After
image image

Display cells

Before After
image image

Existing user relationships migration

Launchcontrol

Adding a new column type for single-user values

Feature branch env

Feature Branch Link

Copy link

linear bot commented Apr 22, 2024

@mike12345567 mike12345567 added the firestorm Data/Infra/Revenue Team label Apr 22, 2024
@adrinr adrinr force-pushed the budi-8123/single-user-column-type branch from efd4f4b to b7688d3 Compare April 25, 2024 11:21
@adrinr adrinr added the do not merge PR is not ready to be merged - generally the PR description should say why label Apr 26, 2024
.eslintrc.json Show resolved Hide resolved
packages/builder/src/constants/backend/index.js Outdated Show resolved Hide resolved
packages/server/src/utilities/schema.ts Outdated Show resolved Hide resolved
packages/types/src/documents/app/row.ts Outdated Show resolved Hide resolved
@adrinr adrinr mentioned this pull request Apr 26, 2024
@adrinr adrinr requested a review from aptkingston April 26, 2024 10:48
Copy link
Member

@aptkingston aptkingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frontend integration looks good to me! Nice one 👌

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking at this - it was a real mess and was spamming API calls.

@adrinr adrinr changed the base branch from master to feat/budi-8123-single-user May 2, 2024 10:56
@adrinr adrinr force-pushed the budi-8123/single-user-column-type branch from 66a9971 to 06b3023 Compare May 2, 2024 11:05
@adrinr adrinr requested a review from samwho May 3, 2024 07:39
@adrinr adrinr merged commit 849cd95 into feat/budi-8123-single-user May 3, 2024
9 checks passed
@adrinr adrinr deleted the budi-8123/single-user-column-type branch May 3, 2024 11:08
@adrinr adrinr mentioned this pull request May 3, 2024
20 tasks
@adrinr adrinr removed the do not merge PR is not ready to be merged - generally the PR description should say why label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-branch Release this PR code into a feature branch firestorm Data/Infra/Revenue Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants