-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single user column type #13543
Merged
adrinr
merged 51 commits into
feat/budi-8123-single-user
from
budi-8123/single-user-column-type
May 3, 2024
Merged
Single user column type #13543
adrinr
merged 51 commits into
feat/budi-8123-single-user
from
budi-8123/single-user-column-type
May 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinr
force-pushed
the
budi-8123/single-user-column-type
branch
from
April 25, 2024 11:21
efd4f4b
to
b7688d3
Compare
adrinr
added
the
do not merge
PR is not ready to be merged - generally the PR description should say why
label
Apr 26, 2024
samwho
reviewed
Apr 26, 2024
Merged
aptkingston
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Frontend integration looks good to me! Nice one 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking at this - it was a real mess and was spamming API calls.
adrinr
force-pushed
the
budi-8123/single-user-column-type
branch
from
May 2, 2024 11:05
66a9971
to
06b3023
Compare
samwho
approved these changes
May 3, 2024
packages/client/src/components/app/forms/RelationshipField.svelte
Outdated
Show resolved
Hide resolved
adrinr
removed
the
do not merge
PR is not ready to be merged - generally the PR description should say why
label
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a new column type for single users. These new columns will return the data as an object, instead of the existing
bb-reference
that returns an array, allowing better validation and cleaner bindings.No existing data will be migrated, the old columns will still return objects and it will keep the constraints validations (allowing multiple or single when required)
With this change, we will have the following strategy:
bb_reference
will be a type that will store an array of internal IDsbb_reference_single
will be a type that will store a single internal IDuser subtype
is allowed, but technically it can support any internal reference such asapps
,groups
,tables
... The subtype will define:i. Input validation: are the IDs valid for that object?
ii. Output enhancement: what other data needs to be populated when enhancing the id
Addresses
Screenshots
Adding a single-user column
Adding a multi-user column
Display cells
Existing user relationships migration
Launchcontrol
Adding a new column type for single-user values
Feature branch env
Feature Branch Link