Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search tests for FieldType.AUTO #13564

Merged
merged 12 commits into from
Apr 26, 2024
Merged

Search tests for FieldType.AUTO #13564

merged 12 commits into from
Apr 26, 2024

Conversation

samwho
Copy link
Collaborator

@samwho samwho commented Apr 25, 2024

Description

Continuing my crusade to write a comprehensive test suite for our search endpoint, this PR adds tests for FieldType.AUTO. This is a field type we only support on internal tables, so these tests do not run against external databases. Also, we know that Lucene does not correctly sort numbers (it uses lexicographical sorting instead of numerical), so I have made the sorting tests only run against SQS.

@samwho samwho changed the title Sqs auto tests SQS tests for FieldType.AUTO Apr 25, 2024
@samwho samwho changed the title SQS tests for FieldType.AUTO Search tests for FieldType.AUTO Apr 25, 2024
@samwho samwho marked this pull request as ready for review April 25, 2024 15:56
@samwho samwho requested a review from a team as a code owner April 25, 2024 15:56
@samwho samwho added the firestorm Data/Infra/Revenue Team label Apr 25, 2024
@samwho samwho enabled auto-merge April 25, 2024 16:26
@samwho samwho requested a review from adrinr April 26, 2024 10:43
@samwho samwho merged commit 8b39641 into master Apr 26, 2024
10 checks passed
@samwho samwho deleted the sqs-auto-tests branch April 26, 2024 14:46
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firestorm Data/Infra/Revenue Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants