Make REUSE_CONTAINERS the default for running tests. #13569
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@PClmnt raised that he keeps running in to the following error when using the
--watch
flag to run tests locally:This was an error I put in place to prevent a situation I found where tests can spin up multiple CouchDB containers but only end up connecting to 1 of them. When you run with
--watch
,testcontainers
never tears any containers down and so when the tests try to bring up another, it fails.I looked to see if there's a way to detect when Jest is running in
--watch
mode but it doesn't seem trivial to do so. I had a play with making aglobalTeardown.ts
file as well but that doesn't run until you fully cancel the--watch
tests.So I've gone for the simple route of just making container reuse the default and getting rid of the
REUSE_CONTAINERS
environment variable.Potential problems with this approach:
I think we can cross those bridges if/when they arise, for now this solves an immediate annoyance.