Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some null reference on builder #13570

Merged
merged 4 commits into from
Apr 26, 2024
Merged

Fix some null reference on builder #13570

merged 4 commits into from
Apr 26, 2024

Conversation

adrinr
Copy link
Collaborator

@adrinr adrinr commented Apr 26, 2024

Description

Found a couple of issues during my demo:

  1. isBetterSample throwing a null reference exception due the shape of the data blocked all column edition or addition
  2. The attachment column type is gone when editing

Launchcontrol

Fixing a couple of frontend bugs on the builder side

@adrinr adrinr requested a review from aptkingston April 26, 2024 13:58
@adrinr adrinr enabled auto-merge April 26, 2024 13:58
@adrinr adrinr merged commit 2afb13d into master Apr 26, 2024
10 checks passed
@adrinr adrinr deleted the fix/isBetterSample-null-reference branch April 26, 2024 14:25
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2024
@adrinr adrinr added the firestorm Data/Infra/Revenue Team label Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mike12345567 mike12345567 mike12345567 approved these changes

@aptkingston aptkingston Awaiting requested review from aptkingston

Assignees
No one assigned
Labels
firestorm Data/Infra/Revenue Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adrinr @mike12345567