Teal bug fixes #13593
Teal bug fixes #13593
Conversation
…ld break event context in further actions
…a link datasource
…a data provider as a source
…noying drag-outside closing actions
| @@ -92,7 +92,8 @@ | |||
| } | |||
|
|
|||
| const addStep = () => { | |||
| value = value.toSpliced($currentStep + 1, 0, {}) | |||
| const newInstance = componentStore.createInstance(componentType) | |||
| value = value.toSpliced($currentStep + 1, 0, newInstance) | |||
There was a problem hiding this comment.
Instead of using an empty object, we now create a fake component instance for each form step. This is how we usually handle these settings, and makes it easier to use later with generic utilities because we have a real component type saved for which we can lookup the definition and settings.
| _id: Helpers.uuid(), | ||
| _component: componentType, | ||
| _id: savedInstance._id || Helpers.uuid(), | ||
| _component: savedInstance._component || componentType, |
There was a problem hiding this comment.
Just re-using the saved properties since they will exist for all new steps after this change. Makes no difference but is how it would be written if we had always saved them.
| }} | ||
| /> | ||
| </AbsTooltip> | ||
| <AbsTooltip text="Next step" noWrap> |
There was a problem hiding this comment.
Wrapping all of these in an AbsTooltip rather than the native tooltip prop of the action button so that the tooltips are rendered on top.
packages/builder/src/dataBinding.js
Outdated
There was a problem hiding this comment.
All nested types are now handled in a single generic way. The old code handled all of these cases apart from fieldConfiguration, and was also very duplicated. This is a single generic way to do this now for all these types of settings.
| resolve(typeof next === "function" ? await next() : true) | ||
| if (typeof next === "function") { | ||
| // Pass the event context back into the new action chain | ||
| resolve(await next(eventContext)) |
There was a problem hiding this comment.
We were just missing the event context param here to the following button actions. The rest is just moving around some code to make it more readable.
| @@ -124,6 +124,7 @@ | |||
| const fieldSchema = schemaFields.find(x => x.name === filter.field) | |||
| filter.type = fieldSchema?.type | |||
| filter.subtype = fieldSchema?.subtype | |||
| filter.formulaType = fieldSchema?.formulaType | |||
There was a problem hiding this comment.
The formula type was missing from the structure we pass into the lucene utils in shared core, which resulted in us being unable to detect static formulae.
Description
This PR is a collection of fixes for issues discovered during building our app.
Fixes
Improvements
rootkey to our configAddresses