Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calendar using locale aware start of week #13599

Merged
merged 1 commit into from
May 2, 2024

Conversation

aptkingston
Copy link
Member

@aptkingston aptkingston commented May 2, 2024

Description

Uses the ISO start of week (Monday) rather than a locale aware start of week (which can be Sunday).

Before (2nd is a Friday, incorrectly):
image

After (2nd is a Thursday, correctly):
image

Addresses

Copy link
Contributor

@deanhannigan deanhannigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aptkingston aptkingston enabled auto-merge May 2, 2024 14:23
@aptkingston aptkingston merged commit 3d4f9b8 into master May 2, 2024
10 checks passed
@aptkingston aptkingston deleted the fix/calendary-start-of-week branch May 2, 2024 14:24
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants