Tests for searching boolean fields, including fixes for various bugs. #13614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samwho
commented
May 3, 2024
Comment on lines
+120
to
+131
| function fixBooleanFields({ row, table }: { row: Row; table: Table }) { | ||
| for (let col of Object.values(table.schema)) { | ||
| if (col.type === FieldType.BOOLEAN) { | ||
| if (row[col.name] === 1) { | ||
| row[col.name] = true | ||
| } else if (row[col.name] === 0) { | ||
| row[col.name] = false | ||
| } | ||
| } | ||
| } | ||
| return row | ||
| } |
There was a problem hiding this comment.
SQS, MariaDB, and MySQL appear to store boolean values as numeric 1s or 0s, this function parses those back into proper booleans.
samwho
commented
May 3, 2024
Comment on lines
+70
to
+84
| private findRow(expectedRow: any, foundRows: any[]) { | ||
| const row = foundRows.find(foundRow => _.isMatch(foundRow, expectedRow)) | ||
| if (!row) { | ||
| const fields = Object.keys(expectedRow) | ||
| // To make the error message more readable, we only include the fields | ||
| // that are present in the expected row. | ||
| const searchedObjects = foundRows.map(row => _.pick(row, fields)) | ||
| throw new Error( | ||
| `Failed to find row: ${JSON.stringify( | ||
| expectedRow | ||
| )} in ${JSON.stringify(searchedObjects)}` | ||
| ) | ||
| } | ||
| return row | ||
| } |
There was a problem hiding this comment.
Added this so that when tests fail because the row searched for does not match any of the rows returned, the message is much nicer. It used to complain about passing undefined to objectContaining, now it looks like this:
samwho
commented
May 3, 2024
mike12345567
reviewed
May 3, 2024
…directly to search.
mike12345567
approved these changes
May 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces tests for searching against boolean fields, which appear to have been quite broken until now. The PR includes fixes for searching against
falsevalues in Lucene, and a variety of fixes required to get searching working for the SQL-based datasources.