Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Fancy Input validation to be triggered onBlur #13658

Merged

Conversation

melohagan
Copy link
Collaborator

Description

Part of the work to improve onboarding email address validation: https://github.com/Budibase/account-portal/pull/612

If validateOn is set to blur, then the validation error message will only trigger on blur, however an existing error message can still be resolved on change.

I.e.

  1. I enter an invalid email address (no error message)
  2. Blur
  3. Error message is shown under the field
  4. I change the input to be valid -> the error message goes away (resolved)
  5. I then enter an invalid address (no error message, back to step 1)

Copy link
Contributor

@jvcalderon jvcalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@melohagan melohagan merged commit efaedbc into master May 10, 2024
10 checks passed
@melohagan melohagan deleted the grow-440-email-address-already-in-use-error-message-is-shown branch May 10, 2024 12:18
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants