Making progress towards deleting sql.spec.ts. #13734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -709,99 +267,4 @@ describe("SQL query builder", () => { | |||
| sql: `insert into "test" ("name") values ($1) returning *`, | |||
| }) | |||
| }) | |||
|
|
|||
| it("should be able to rename column for MySQL", () => { | |||
| const table: Table = { | |||
There was a problem hiding this comment.
Is this covered as part of the table tests now?
There was a problem hiding this comment.
I had thought it was but on second look it's not. I'll add rename tests to table.spec.ts.
There was a problem hiding this comment.
Okay looked closer and we do have a test for this, "updates all the row fields for a table when a schema key is renamed" in table.spec.ts
mike12345567
approved these changes
May 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The main aim of this PR is to delete
sql.spec.ts, replacing the things it's testing with integration tests in eithersearch.spec.ts,row.spec.ts, ortable.spec.ts.I haven't achieved that, but I have managed to shorten it so it has much less overlap with existing integration tests.
On my way through this, I renamed
external.spec.tstosearch.spec.tsand upgraded it to a generic test against all datasources for our search SDK. Its job is to test whatever can't be tested through the API.I felt I'd hit a good checkpoint, but would like to follow this up with another PR further trimming down what's in
sql.spec.ts.