Fixing issue with multiple automation steps of the same type showing same response #3998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om chevron div and using the action button in the automation code editor so that bindings can be hidden/shown if they are taking up too much of screen.
…d in the same automation would have the same response output in the frontend, this was a visual bug. Also fixing an issue introduced by REST update that broke the query controller.
Codecov Report
@@ Coverage Diff @@
## develop #3998 +/- ##
========================================
Coverage 68.89% 68.89%
========================================
Files 139 139
Lines 4630 4630
Branches 685 685
========================================
Hits 3190 3190
Misses 1017 1017
Partials 423 423
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a frontend visual issue denoted in #3722 - when automation steps of the same type were added to the same automation the test results would show the same for each step - this was due to how the frontend was selecting the test result for each step (it was just using the
stepIdwhich is the type of step, rather than the uniqueidproperty).Also performed some quick visual updates to the automation frontend, there was a custom button used which was easily replaced with an
ActionButtonand used the same action button in the automation code editor which had all bindings displayed within it, allowing collapsing of the bindings to make the editor a bit cleaner to look at.Screenshots
Setup was previously a div with some custom stuff going on to flip the chevron, replaced with an
ActionButton.Automation code editor, with bindings closed.
Automation code editor, bindings opened.