Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation for query preview endpoint #4414

Merged
merged 3 commits into from
Feb 11, 2022
Merged

Fix validation for query preview endpoint #4414

merged 3 commits into from
Feb 11, 2022

Conversation

mslourens
Copy link
Contributor

Description

It is currently not possible to preview a REST query, it throws errors because the validation is missing three fields. This PR fixes that.

Fixes #4413

Copy link
Member

@shogunpurple shogunpurple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @mslourens - thanks!

@shogunpurple
Copy link
Member

Hmm, seems like the tests need to be updated to reflect this also according to CI

@codecov-commenter
Copy link

Codecov Report

Merging #4414 (7b182b1) into develop (0890c3d) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4414      +/-   ##
===========================================
- Coverage    67.91%   67.89%   -0.03%     
===========================================
  Files          144      144              
  Lines         4922     4922              
  Branches       761      761              
===========================================
- Hits          3343     3342       -1     
  Misses        1105     1105              
- Partials       474      475       +1     
Impacted Files Coverage Δ
...ges/server/src/api/controllers/query/validation.js 100.00% <ø> (ø)
packages/server/src/api/controllers/query/index.js 74.73% <0.00%> (-1.06%) ⬇️
packages/server/src/middleware/joi-validator.js 76.47% <0.00%> (ø)
packages/server/src/api/controllers/integration.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a557d32...7b182b1. Read the comment docs.

@shogunpurple shogunpurple merged commit 933693b into Budibase:develop Feb 11, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to preview REST query
3 participants