Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward Host header to worker and server through NGINX #4599

Merged
merged 2 commits into from
Feb 21, 2022
Merged

Forward Host header to worker and server through NGINX #4599

merged 2 commits into from
Feb 21, 2022

Conversation

Rory-Powell
Copy link
Contributor

Description

Fixes #4547

  • Forward the Host header through nginx
  • This fixes tenancy parsing for subdomains
  • Which fixes app list retrieval for matching custom urls
  • Did not affect self host due to single tenancy

shogunpurple
shogunpurple approved these changes Feb 21, 2022
View reviewed changes
Copy link
Member

@shogunpurple shogunpurple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good catch - I think you could probably set this inside the http block, and then you don't need to set it inside each location - I could be wrong

@Rory-Powell
Copy link
Contributor Author

Good call @shogunpurple . Setting at the http level works for all sub locations. Added in 3ee7997

@Rory-Powell Rory-Powell merged commit 65092a4 into master Feb 21, 2022
@Rory-Powell Rory-Powell deleted the hotfix/public-app-url branch February 21, 2022 10:49
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shogunpurple shogunpurple shogunpurple approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Rory-Powell @shogunpurple