-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table Row Selection #4638
Table Row Selection #4638
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4638 +/- ##
========================================
Coverage 67.91% 67.91%
========================================
Files 144 144
Lines 4922 4922
Branches 761 761
========================================
Hits 3343 3343
Misses 1105 1105
Partials 474 474 Continue to review full report at Codecov.
|
…able-row-selection
… feature/table-row-selection
…able-row-selection
…unting tables, remove position absolute on row selection text
…or tables inside table blocks to support row selection bindings
…on bindings for table blocks, update readable text for row selection bindings
…able-row-selection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff Peter! Trying to get these cypress tests to pass and then let's get this merged.
…able-row-selection
…able-row-selection
Description
This PR adds the ability to select / multi-select a number of rows in a table and use them in bindings. This will allow cool stuff like the exporting of specific table in a data, or you could select a number of rows and pass them to automations using a button action etc. Stuff like that.
You can enable this feature by clicking this checkbox in the Table settings
A couple of changes have been made to the BBUI table component in order to enable this. There was an already the ability to select rows in the data tab, but you lost your selection every time you navigated to a new page, this PR fixes that and your selection is maintained over whatever amount of pages you have in the table.
Also new is the Checkbox used to select all rows on your current page (just added to the top left corner like here: https://spectrum.adobe.com/page/table/). This Checkbox will only select the rows on that page, not for the entire table. There's a little bit of hacky code in here as well, that basically ensures the Checkbox deselects when you navigate to a new page with no rows. The functuionality around this is never going to be perfect, essentially because the table has no idea what page it is as Pagination is a separate area altogether.
You can also see in the below screenshot that a row count has been added, just to keep track of what size your currrent selection is.
To allow for the handling of multiple tables, each selection is shown in the binding drawer like so
Screenshots
Each of these are just an array of Row IDs.
Updates
A few quick updates made after review: