Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix soft bricking app when closing nested modals using escape key #4734

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

aptkingston
Copy link
Member

@aptkingston aptkingston commented Feb 28, 2022

Description

This fixes an issue where using the escape key to close modals when modals are nested inside each other lead to a soft bricking of the app, forcing a refresh.

Fixes #4660.

Merging into develop rather than master as not very high priority.

@codecov-commenter
Copy link

Codecov Report

Merging #4734 (c4ebc85) into develop (f37a4ee) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4734   +/-   ##
========================================
  Coverage    67.91%   67.91%           
========================================
  Files          144      144           
  Lines         4922     4922           
  Branches       761      761           
========================================
  Hits          3343     3343           
  Misses        1105     1105           
  Partials       474      474           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cf0011...c4ebc85. Read the comment docs.

@aptkingston aptkingston merged commit 7783e4d into develop Mar 1, 2022
@aptkingston aptkingston deleted the fix/esc-nested-modals branch March 1, 2022 09:42
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pressing esc while deleting a column causes a soft lock
3 participants