Changes for Table test - Commands.js #4751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like a potential timing issue for the Create Table test Specifically: -The datasource modal looks to be sometimes delayed when appearing after app creation --increasing wait time for after app creation --Reducing wait within the createTable command --Updating specific ID to use 'data-cy' --Updating another ID for the data source modal I am unable to reproduce this potential issue locally, so making changes in hopes the CI picks it up (if the timing issue still exists)
PClmnt
approved these changes
Mar 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like a potential timing issue for the Create Table test
Specifically:
-The datasource modal looks to be sometimes delayed when appearing after app creation
--increasing wait time for after app creation
--Reducing wait within the createTable command
--Updating specific ID to use 'data-cy'
--Updating another ID for the data source modal
I am unable to reproduce this potential issue locally, so making changes in hopes the CI picks it up (if the timing issue still exists)