Properly remove window event listener when unmounting component preview #4820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4820 +/- ##
=======================================
Coverage 67.91% 67.91%
=======================================
Files 144 144
Lines 4922 4922
Branches 761 761
=======================================
Hits 3343 3343
Misses 1105 1105
Partials 474 474 Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue reported in #4797 (comment). Thanks to @GlitchWitch for providing a video which helped me diagnose the issue.
We weren't properly removing an event listener when unmounting the component preview, which mean that if you toggled between the data and design section multiple times, new listeners would be created. This meant that whenever an even was sent from the iframe, it was handled multiple times. This causes lots of conflicts, and may have been the source of multiple other bugs as well.