Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show correct error and keep modal open #4838

Merged
merged 1 commit into from
Mar 8, 2022
Merged

show correct error and keep modal open #4838

merged 1 commit into from
Mar 8, 2022

Conversation

mslourens
Copy link
Contributor

Description

When the connection to a data source fails, a very generic error is thrown and the modal is closed. This should not happen, the user should be able to fix the issue and know what's wrong. This PR fixes #4812

Screenshots

image

@codecov-commenter
Copy link

Codecov Report

Merging #4838 (4df23dd) into develop (86f649c) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4838      +/-   ##
===========================================
- Coverage    69.51%   69.45%   -0.06%     
===========================================
  Files          145      145              
  Lines         4979     4983       +4     
  Branches       765      766       +1     
===========================================
  Hits          3461     3461              
- Misses        1066     1069       +3     
- Partials       452      453       +1     
Impacted Files Coverage Δ
...kages/server/src/api/controllers/table/external.js 7.97% <0.00%> (-0.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 946d245...4df23dd. Read the comment docs.

Copy link
Member

@shogunpurple shogunpurple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix here! Thanks @mslourens

@shogunpurple shogunpurple merged commit 1e61793 into Budibase:develop Mar 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data source modal closes on error
3 participants