Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update how button action for exporting works #4842

Merged
merged 3 commits into from
Mar 8, 2022

Conversation

PClmnt
Copy link
Collaborator

@PClmnt PClmnt commented Mar 8, 2022

Description

Updates how the button action works for the export data action.

  • It now takes a table component id, instead of a backend table ID.
  • Also update some of the UX for the button action, to make it a little tidier.

image

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2022

Codecov Report

Merging #4842 (7d9bed3) into develop (ea63b9b) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4842      +/-   ##
===========================================
- Coverage    69.23%   69.18%   -0.06%     
===========================================
  Files          145      145              
  Lines         5003     5007       +4     
  Branches       766      767       +1     
===========================================
  Hits          3464     3464              
- Misses        1086     1089       +3     
- Partials       453      454       +1     
Impacted Files Coverage Δ
...kages/server/src/api/controllers/table/external.js 7.97% <0.00%> (-0.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea63b9b...7d9bed3. Read the comment docs.

Copy link
Member

@aptkingston aptkingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@shogunpurple shogunpurple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PClmnt PClmnt merged commit b79653c into develop Mar 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants