Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link in pkexec email URL searches for title=log4j, no matches #36

Closed
jezzaaa opened this issue Jan 26, 2022 · 3 comments
Closed

Link in pkexec email URL searches for title=log4j, no matches #36

jezzaaa opened this issue Jan 26, 2022 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@jezzaaa
Copy link

jezzaaa commented Jan 26, 2022

Great service. Best of luck with it.

I just read the notice email for the pkexec bug. The link for "Discussion can be found on Github" links to
https://github.com/sullivanmatt/bugalert/pulls?q=is%3Apr+in%3Atitle+log4j
which appears to be referencing log4j. The q= query string is "is:pr in:title log4j". The result is "no results matched your search." Perhaps the search term should be "is:pr in:title pkexec" for this bug?
@sullivanmatt sullivanmatt added the bug Something isn't working label Jan 26, 2022
@sullivanmatt
Copy link
Collaborator

Link hardcoded: https://github.com/BugAlertDotOrg/bugalert/blob/main/notice_communication/email_content.py#L614

Needs to be replaced with the {slug} variable during str format.

@sullivanmatt sullivanmatt added the good first issue Good for newcomers label Jan 26, 2022
@Thelvaen
Copy link

Still the case with the Spring notice we just received.
Regards,

ethans added a commit to ethans/bugalert that referenced this issue Mar 30, 2022
@ethans
Fix for Issue BugAlertDotOrg#36 - all emails search for log4j PR inst…
10d193a 
…ead of {slug}
sullivanmatt added a commit that referenced this issue Mar 30, 2022
@sullivanmatt
Merge pull request #44 from ethans/main
cb9fe4e 
Fix for Issue #36 - all emails search for log4j PR instead of {slug}
@sullivanmatt
Copy link
Collaborator

Resolved by #44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sullivanmatt @jezzaaa @Thelvaen