Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflexion color dayanimation background #248

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bilalesi
Copy link

change the single quote to double quote for consistency for daySelectionAnimation properties
in the background interface

@peacechen
Copy link
Collaborator

@bilalesi Does this replace PR #244 ? I made some comments on that PR that should be addressed before it can be merged. There's now a conflict in index.d.ts. I recommend that you pull the latest from the main branch here and sync up with recent changes.

@peacechen
Copy link
Collaborator

@bilalesi Would you mind resolving the conflicts in index.d.ts ?

The Readme also needs to be updated to document the new key for the daySelectionAnimation prop.
https://github.com/BugiDev/react-native-calendar-strip#day-selection-animation-options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants