Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair enchants don't work properly #3119

Closed
Unknown-Zombie opened this issue Nov 8, 2015 · 3 comments
Closed

Repair enchants don't work properly #3119

Unknown-Zombie opened this issue Nov 8, 2015 · 3 comments
Labels
type: enhancement Something small that would improve buildcraft

Comments

@Unknown-Zombie
Copy link

In 7.1.12 the change log says that Mining Robots take advantage of enchants now. Should this extend to any robot that uses a tool? I have given a Tinker's Construct tool with Repair on it to a Lumberjack Robot, but the tool doesn't actually repair itself while the robot holds it.

@asiekierka
Copy link
Member

I meant vanilla enchants, not these. I am not sure if I can even support things like Repair correctly.

Dnia 8 lis 2015 o godz. 02:45 James A. Gilmore II notifications@github.com napisał(a):

In 7.1.12 the change log says that Mining Robots take advantage of enchants now. Should this extend to any robot that uses a tool? I have given a Tinker's Construct tool with Repair on it to a Lumberjack Robot, but the tool doesn't actually repair itself while the robot holds it.


Reply to this email directly or view it on GitHub.

@Unknown-Zombie
Copy link
Author

Understood; it's not a big deal.

@iTitus
Copy link
Collaborator

iTitus commented Nov 8, 2015

If the onUpdate(...) method of the Item is called, that TiC modifier should work, but this could also cause some problems.

asiekierka added a commit that referenced this issue Nov 9, 2015
@asiekierka asiekierka added the type: enhancement Something small that would improve buildcraft label Nov 9, 2015
@asiekierka asiekierka added this to the BuildCraft 7.1.14 milestone Nov 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Something small that would improve buildcraft
Projects
None yet
Development

No branches or pull requests

3 participants