New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced bounding boxes #1581
Enhanced bounding boxes #1581
Conversation
Thanks! I'll try it out and merge. 6.0.x is reasonable for this change I would say, so I'll put it on NextGen indeed. |
AxisAlignedBB[] aabbs = boxes[((TileEngine)tile).orientation.ordinal()]; | ||
for (AxisAlignedBB aabb : aabbs) { | ||
aabb = aabb.getOffsetBoundingBox(x, y, z); | ||
if (mask.intersectsWith(aabb)){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That line doesn't compile when merging. Where is this variable mask supposed to be coming from?
Whoops, it was 'full' AxisAlignedBB. Fixed. |
Making the same thing for lasers now =D |
Let's hope i didn't forget anything. P.S. Hey, just realized, collisionRayTrace and addCollisionBoxesToList methods is universal, because of 'for' cycle(and BlockHighlightHandler). |
Works great on my setup, good work! Merged, will go in BC 6.0.6. |
I know, what i forget, BlockHighlightHandler registration, but i think, you fixed it =) EDIT:(ok, you fix import, but registration needs to be moved to core class. Not a big thing for whole PR, so just i mention it to you here) |
So let me make sure I understand: MinecraftForge.EVENT_BUS.register(new BlockHighlightHandler()); Needs to be in BuildCraftCore? |
Yes, because it is used in Enegry and Silicon(and it can be used elsewhere). |
I use NextGen in my workspace(so i can check new cool things =P), so i'm not sure, will it work on other branches.
Also, i can access this filler now! =)
More screenshots: