Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced bounding boxes #1581

Merged
merged 12 commits into from Apr 9, 2014
Merged

Enhanced bounding boxes #1581

merged 12 commits into from Apr 9, 2014

Conversation

ghost
Copy link

@ghost ghost commented Apr 6, 2014

I use NextGen in my workspace(so i can check new cool things =P), so i'm not sure, will it work on other branches.

Also, i can access this filler now! =)
2014-04-06_17 55 06
More screenshots:
2014-04-07_19 18 22
2014-04-07_19 18 33
2014-04-07_19 18 44

@SpaceToad
Copy link
Member

Thanks! I'll try it out and merge. 6.0.x is reasonable for this change I would say, so I'll put it on NextGen indeed.

AxisAlignedBB[] aabbs = boxes[((TileEngine)tile).orientation.ordinal()];
for (AxisAlignedBB aabb : aabbs) {
aabb = aabb.getOffsetBoundingBox(x, y, z);
if (mask.intersectsWith(aabb)){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That line doesn't compile when merging. Where is this variable mask supposed to be coming from?

@ghost
Copy link
Author

ghost commented Apr 8, 2014

Whoops, it was 'full' AxisAlignedBB. Fixed.

@ghost
Copy link
Author

ghost commented Apr 8, 2014

Making the same thing for lasers now =D

@ghost ghost changed the title Enhanced engine bounding box Enhanced bounding boxes Apr 8, 2014
@ghost
Copy link
Author

ghost commented Apr 8, 2014

Let's hope i didn't forget anything.
http://imgur.com/rWDSJGr,sLIjoxx,aqhcTfH,q00vRNk,1C4Sgw3,P5anvAn,vu7Dhcq

P.S. Hey, just realized, collisionRayTrace and addCollisionBoxesToList methods is universal, because of 'for' cycle(and BlockHighlightHandler).

@SpaceToad SpaceToad added this to the BuildCraft 6.0.6 milestone Apr 9, 2014
@SpaceToad SpaceToad assigned ghost Apr 9, 2014
@SpaceToad SpaceToad merged commit ab0427e into BuildCraft:NextGen Apr 9, 2014
@SpaceToad
Copy link
Member

Works great on my setup, good work! Merged, will go in BC 6.0.6.

@ghost
Copy link
Author

ghost commented Apr 9, 2014

I know, what i forget, BlockHighlightHandler registration, but i think, you fixed it =)

EDIT:(ok, you fix import, but registration needs to be moved to core class. Not a big thing for whole PR, so just i mention it to you here)

@ghost ghost deleted the NextGen branch April 9, 2014 13:32
@SpaceToad
Copy link
Member

So let me make sure I understand:

MinecraftForge.EVENT_BUS.register(new BlockHighlightHandler());

Needs to be in BuildCraftCore?

@ghost
Copy link
Author

ghost commented Apr 10, 2014

Yes, because it is used in Enegry and Silicon(and it can be used elsewhere).

@Fluffy9911 Fluffy9911 mentioned this pull request Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Something small that would improve buildcraft
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant