-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sdk): Allow passing readonly arrays #3308
Conversation
🦋 Changeset detectedLatest commit: 88d9882 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this fix!
I don't have write permissions to this PR, but we need to add a Changesets file so that we can publish your changes properly. Mind merging this PR or providing write permissions so I can make the change? https://github.com/Oak-Digital/builder/pull/1/files#diff-e1ba98944d0ca436baa0fdf8fb51f74d56e420ea215c44ae93a16aac0392cf97 |
Add changeset
Description
It should be possible to assign readonly types to
Component
and other@builder.io/sdk
types, since no mutations are(/should) happening.This is needed to make type inference working in the
@oak-digital/builder-helpers
package.See the following example:
This example would result in a type error while registering the component to builder. This is not really desired, so this PR makes it possible to ALSO assign readonly types.
This PR fixes #3293