Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: polyfill __dirname in esm #63

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

danielroe
Copy link
Contributor

Otherwise when utils/index.mjs is imported we get the following error:

 ERROR  __dirname is not defined

  at libDirPath (node_modules/@builder.io/partytown/utils/index.mjs:16:20)

@vercel
Copy link

vercel bot commented Feb 3, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/builder-io/partytown/E7VV42iDdPTfByrMjQczuCbbv3x6
✅ Preview: Failed

danielroe added a commit to nuxt-modules/partytown that referenced this pull request Feb 3, 2022
@adamdbradley adamdbradley merged commit 2652818 into BuilderIO:main Feb 3, 2022
@adamdbradley
Copy link
Contributor

Great fix, thanks!

@danielroe danielroe deleted the fix/esm-dirname branch February 3, 2022 17:33
sanyamkamat pushed a commit to sanyamkamat/partytown that referenced this pull request Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants