Merge branch 'main' into patch-5

.devcontainer/Dockerfile

@@ -1,27 +1,6 @@
-FROM node:17.9.0-buster
+FROM cimg/rust:1.65.0-node
 
-ENV RUSTUP_HOME=/usr/local/rustup \
-    CARGO_HOME=/usr/local/cargo \
-    PATH=/usr/local/cargo/bin:$PATH \
-    RUST_VERSION=1.61.0
-
-RUN set -eux; \
-    dpkgArch="$(dpkg --print-architecture)"; \
-    case "${dpkgArch##*-}" in \
-        amd64) rustArch='x86_64-unknown-linux-gnu'; rustupSha256='3dc5ef50861ee18657f9db2eeb7392f9c2a6c95c90ab41e45ab4ca71476b4338' ;; \
-        armhf) rustArch='armv7-unknown-linux-gnueabihf'; rustupSha256='67777ac3bc17277102f2ed73fd5f14c51f4ca5963adadf7f174adf4ebc38747b' ;; \
-        arm64) rustArch='aarch64-unknown-linux-gnu'; rustupSha256='32a1532f7cef072a667bac53f1a5542c99666c4071af0c9549795bbdb2069ec1' ;; \
-        i386) rustArch='i686-unknown-linux-gnu'; rustupSha256='e50d1deb99048bc5782a0200aa33e4eea70747d49dffdc9d06812fd22a372515' ;; \
-        *) echo >&2 "unsupported architecture: ${dpkgArch}"; exit 1 ;; \
-    esac; \
-    url="https://static.rust-lang.org/rustup/archive/1.24.3/${rustArch}/rustup-init"; \
-    wget "$url"; \
-    echo "${rustupSha256} *rustup-init" | sha256sum -c -; \
-    chmod +x rustup-init; \
-    ./rustup-init -y --no-modify-path --profile minimal --default-toolchain $RUST_VERSION --default-host ${rustArch}; \
-    rm rustup-init; \
-    chmod -R a+w $RUSTUP_HOME $CARGO_HOME; \
-    rustup --version; \
+RUN rustup --version; \
     cargo --version; \
     rustc --version; \
     rustup update; \

.devcontainer/devcontainer.json

@@ -2,16 +2,9 @@
 // https://github.com/microsoft/vscode-dev-containers/tree/v0.217.2/containers/docker-existing-dockerfile
 {
   "name": "Qwik devcontainer",
-
-  // Sets the run context to one level up instead of the .devcontainer folder.
-  "context": "..",
-
-  // Update the 'dockerFile' property if you aren't using the standard 'Dockerfile' filename.
-  "dockerFile": "./Dockerfile",
-
-  // Set *default* container specific settings.json values on container create.
-  "settings": {},
-
+  "hostRequirements": {
+    "cpus": 4
+  },
   // Add the IDs of extensions you want installed when the container is created.
   "extensions": [
     "esbenp.prettier-vscode",
@@ -24,5 +17,22 @@
     "silvenon.mdx",
     "csstools.postcss"
   ],
-  "postStartCommand": "yarn install"
+  "features": {
+    "ghcr.io/devcontainers/features/node:1": {},
+    "ghcr.io/devcontainers/features/rust:1": {}
+  },
+  "waitFor": "onCreateCommand",
+  "updateContentCommand": "pnpm install",
+  "forwardPorts": [3300, 9229],
+  "customizations": {
+    "codespaces": {
+      "openFiles": ["CONTRIBUTING.md"]
+    }
+  },
+  "portsAttributes": {
+    "3300": {
+      "label": "Serve",
+      "onAutoForward": "openPreview"
+    }
+  }
 }

.eslintignore

@@ -21,4 +21,5 @@ packages/docs/src/routes/examples/apps/**/*
 packages/docs/src/routes/playground/app/**/*
 packages/docs/src/routes/tutorial/**/*
 starters/apps/base
+starters/apps/library
 vite.config.ts

.github/PULL_REQUEST_TEMPLATE.md

@@ -10,14 +10,14 @@ Please include a summary of the change and which issue is fixed. Please also inc
 
 # Use cases and why
 
-<!-- Actual / expected behaviour if it's a bug -->
+<!-- Actual / expected behavior if it's a bug -->
 
 - 1. One use case
 - 2. Another use case
 
 # Checklist:
 
-- [ ] My code follows the [developer guidelines of this project](../CONTRIBUTING.md)
+- [ ] My code follows the [developer guidelines of this project](https://github.com/BuilderIO/qwik/blob/main/CONTRIBUTING.md)
 - [ ] I have performed a self-review of my own code
 - [ ] I have made corresponding changes to the documentation
 - [ ] Added new tests to cover the fix / functionality

.github/workflows/bench.yml

@@ -28,12 +28,14 @@ jobs:
       - uses: actions/checkout@v3
 
       - name: Cache
-        uses: actions/cache@v1
+        uses: actions/cache@v3
         with:
           path: |
-            ./cache
-            ~/.cargo/
-            target
+            ~/.cargo/bin/
+            ~/.cargo/registry/index/
+            ~/.cargo/registry/cache/
+            ~/.cargo/git/db/
+            target/
           key: cargo-bench-${{ runner.os }}-${{ hashFiles('**/Cargo.lock') }}
           restore-keys: |
             cargo-bench-${{ runner.os }}-${{ hashFiles('**/Cargo.lock') }}