Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dx: Improve/Update Code Snippets #1060

Merged
merged 8 commits into from Sep 26, 2022

Conversation

nnelgxorz
Copy link
Contributor

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@nnelgxorz nnelgxorz changed the title dx: Improve Code Snippets dx: Improve Component Code Snippets Aug 13, 2022
@nnelgxorz nnelgxorz changed the title dx: Improve Component Code Snippets dx: Improve/Update Code Snippets Aug 14, 2022
@nnelgxorz
Copy link
Contributor Author

@manucorporat How would you feel about prefixing all of these with something like q:, that way you can type q: and have a full list of snippets in your intellisense and it removes ambiguity between intellisense for Qwik functions/imports and snippets?
q:code-snippets

@manucorporat
Copy link
Contributor

yeah! i like the idea! lets prefix them

@nnelgxorz
Copy link
Contributor Author

Just have a few more tweaks to make and then I'll be ready to get this merged. 👍

@manucorporat
Copy link
Contributor

Think you can finish the PR? otherwise i might take it :)

@nnelgxorz
Copy link
Contributor Author

@manucorporat Will definitely wrap this up Monday or Tuesday

@nnelgxorz nnelgxorz marked this pull request as ready for review September 21, 2022 01:32
@manucorporat manucorporat merged commit 3294cb9 into QwikDev:main Sep 26, 2022
@manucorporat
Copy link
Contributor

AMAZING as usual! merged

@nnelgxorz
Copy link
Contributor Author

Thanks @manucorporat!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants