refactor: move global Q config to document links #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamdbradley
force-pushed
the
remove-global-q
branch
from
e92bfb7
to
3f2d725
Compare
mhevery
approved these changes
Jun 21, 2021
src/core/import/qImport.ts
Outdated
| base: Element | Document | string | QConfig, | ||
| url: string | QRL<T> | URL | ||
| ): T | Promise<T> { | ||
| export function qImport<T>(base: Element | Document, url: string | QRL<T> | URL): T | Promise<T> { | ||
| if (!importCache) importCache = new Map<string, unknown | Promise<unknown>>(); |
There was a problem hiding this comment.
As it stands now, I think this will not behave correctly. On a server, one can serve different apps. These apps will have different configurations but may have the same protocol. The above will leak data between the applications. Let's remove this cache altogether.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.