Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note regarding destructuring assignment of state #1454

Merged
merged 1 commit into from Sep 26, 2022

Conversation

voluntadpear
Copy link
Contributor

@voluntadpear voluntadpear commented Sep 25, 2022

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

This PR introduces a simple note to avoid people from assuming that they can use direct references to properties of the reactive object returned by useStore and then realizing that reactivity doesn't work in that case.

Based on https://discord.com/channels/842438759945601056/843151429479956510/1023347860600803368

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@manucorporat
Copy link
Contributor

Nice improvement!! thank you

@manucorporat manucorporat merged commit 02b3b79 into QwikDev:main Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants