Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Let developers make their own error pages design #1636

Closed
wants to merge 1 commit into from

Conversation

devmousa
Copy link
Contributor

@devmousa devmousa commented Oct 7, 2022

What is it?

  • Feature / enhancement
  • Bug

Description

Make simple changes to let developers make their own error pages and design as they want
the developer should make designs for each error page
if this PR merged and accepted, I'll update the rest of files and make more error pages to be ready for design

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@RafaelZasas
Copy link

I really like this implementation, although it does shoehorn users into naming their pages with err-<errStatus>-page and limited options for the url of error routes.

Would it be possible to allow the user to define the dir of their choice for errors as well as the component name? maybe to set window.location.href to a ${errPageLocation} or even having an optional JSX Element prop which would return the actual component itself instead of navigating to a pre defied route?

@adamdbradley
Copy link
Contributor

Thanks for opening the PR, but we had to fix this with a different approach to allow for a custom 404 to work and various directories. #2175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants